Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24995][tests] EnumValueSerializerCompatibilityTest doesn't compile on later Scala versions #17978

Merged
merged 2 commits into from Jun 14, 2022

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Dec 1, 2021

ConsoleReporter#printSummary was removed in 2.12.13 and 2.13.0. We can use #finish instead which is equivalent and available in all versions.

https://www.scala-lang.org/api/2.12.7/scala-compiler/scala/tools/nsc/reporters/ConsoleReporter.html#finish():Unit
https://www.scala-lang.org/api/2.12.12/scala-compiler/scala/tools/nsc/reporters/ConsoleReporter.html#finish():Unit
https://www.scala-lang.org/api/2.13.7/scala-compiler/scala/tools/nsc/reporters/ConsoleReporter.html#finish():Unit

Additionally the test now fails if the compiler reports a warning or error, so we actually get some benefit from the summary.
Alternatively, we could also just remove it, but I can't really decide that.

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 1, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d0580ff (Wed Dec 01 11:24:09 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 1, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol
Copy link
Contributor Author

zentol commented Dec 1, 2021

@flinkbot run azure

- 'in' variable was unused
- 'out' variable was unnecessary because the reporter by default prints to stderr anyway, and there isn't a real benefit in using stdout
'ConsoleReporter#finish' behaves just like '#printSummary', but is also supported in later versions.
Additionally, we now fail the test if the compiler reported any warnings/errors, as without it the summary business didn't provide a benefit in the first place.
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zentol
Copy link
Contributor Author

zentol commented Jun 13, 2022

@flinkbot run azure

@zentol zentol merged commit 12b41d0 into apache:master Jun 14, 2022
@zentol zentol deleted the 24995 branch September 2, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants