Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-24995][tests] EnumValueSerializerCompatibilityTest doesn't compile on later Scala versions #17978

Merged
merged 2 commits into from Jun 14, 2022
Merged

[FLINK-24995][tests] EnumValueSerializerCompatibilityTest doesn't compile on later Scala versions #17978

merged 2 commits into from Jun 14, 2022

Commits on Jun 13, 2022

  1. [hotfix] Cleanup EnumValueSerializerCompatibilityTest 

    - 'in' variable was unused
- 'out' variable was unnecessary because the reporter by default prints to stderr anyway, and there isn't a real benefit in using stdout
    @zentol
    zentol committed Jun 13, 2022
    Copy the full SHA
    f5c6abb View commit details
    Browse the repository at this point in the history

  2. [FLINK-24995][tests] Migrate tests to ConsoleReporter#finish 

    'ConsoleReporter#finish' behaves just like '#printSummary', but is also supported in later versions.
Additionally, we now fail the test if the compiler reported any warnings/errors, as without it the summary business didn't provide a benefit in the first place.
    @zentol
    zentol committed Jun 13, 2022
    Copy the full SHA
    1800ab7 View commit details
    Browse the repository at this point in the history