New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25222][tests] Remove NetworkFailureProxy used in Kafka tests #18057
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 999dcc9 (Tue Dec 14 09:07:36 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@flinkbot run azure |
We suspect that the NetworkFailureProxy is causing constant connectivity problems to the brokers during testing resulting in either network timeouts or corrupted results. Since the NetworkFailureProxy is only used for testing the deprecated FlinkKafkaProducer/Consumer we can safely remove it because we will not add new features to the connectors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
What is the purpose of the change
We suspect that the NetworkFailureProxy is causing constant connectivity
problems to the brokers during testing resulting in either network
timeouts or corrupted results.
Since the NetworkFailureProxy is only used for testing the deprecated
FlinkKafkaProducer/Consumer we can safely remove it because we will not
add new features to the connectors.
Brief change log
Verifying this change
Only test code has changed and all existing tests still pass
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation