Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-25222][tests] Remove NetworkFailureProxy used in Kafka tests #18101

Merged
merged 3 commits into from Dec 15, 2021

Conversation

fapaul
Copy link

@fapaul fapaul commented Dec 14, 2021

Unchanged backport of #18057

Fabian Paul added 3 commits December 14, 2021 10:08
We suspect that the NetworkFailureProxy is causing constant connectivity
problems to the brokers during testing resulting in either network
timeouts or corrupted results.
Since the NetworkFailureProxy is only used for testing the deprecated
FlinkKafkaProducer/Consumer we can safely remove it because we will not
add new features to the connectors.
@flinkbot
Copy link
Collaborator

flinkbot commented Dec 14, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 60e9a62 (Tue Dec 14 09:16:14 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@fapaul
Copy link
Author

fapaul commented Dec 14, 2021

@flinkbot run azure

1 similar comment
@fapaul
Copy link
Author

fapaul commented Dec 15, 2021

@flinkbot run azure

@fapaul fapaul merged commit 8a939cc into apache:release-1.14 Dec 15, 2021
@fapaul fapaul deleted the FLINK-25222-4 branch December 15, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants