Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-26016][hive] Fix FileSystemLookupFunction can't build correct cache when reading columnar storage table #18777

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

hackergin
Copy link
Contributor

@hackergin hackergin commented Feb 15, 2022

What is the purpose of the change

*Fix lookup join bug when reading hive columnar storage tables. *

Brief change log

  • When building the cache, generate cache key after copy the RowData from columnar RowData in case of different key reference the same memory

Verifying this change

This change added tests and can be verified as follows:

Unit tests

  • Add test in [HiveLookupJoinITCase.java] to test lookup join with columnar table and make sure there is enough records to make sure the ParquetVectorizedInputFormat will read at least two batch to reproduce the error

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit fcaabbf (Tue Feb 15 10:49:52 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 15, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…rect results when hive table uses columnar storage
@luoyuxia
Copy link
Contributor

@hackergin Thanks for contribution. LGTM.
@wuchong @JingsongLi Do you have time to help review&merge?

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution!

@JingsongLi JingsongLi merged commit faf9a8a into apache:master Feb 21, 2022
@JingsongLi
Copy link
Contributor

@hackergin can you create pr for release-1.14?

@hackergin
Copy link
Contributor Author

@JingsongLi sure.

hackergin added a commit to hackergin/flink that referenced this pull request Feb 21, 2022
…rect results when hive table uses columnar storage

This closes apache#18777
hackergin added a commit to hackergin/flink that referenced this pull request Feb 21, 2022
…rect results when hive table uses columnar storage

This closes apache#18777
hackergin added a commit to hackergin/flink that referenced this pull request Feb 21, 2022
…rect results when hive table uses columnar storage

This closes apache#18777
MrWhiteSike pushed a commit to MrWhiteSike/flink that referenced this pull request Mar 3, 2022
…rect results when hive table uses columnar storage

This closes apache#18777
@hackergin
Copy link
Contributor Author

@JingsongLi I submitted the pr for release-1.14 #18857

JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…rect results when hive table uses columnar storage

This closes apache#18777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants