[FLINK-27317][build] Don't fork build for attaching sources #19524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvk
reviewed
Apr 20, 2022
There was a problem hiding this comment.
This is some dark working directory magic. :) How about making the .scalafmt.conf path relative to the base directory instead? Are there any other consequences of using -no-fork?
eg.
index ff31c8996bb..ad805f54d6d 100644
--- a/flink-scala/pom.xml
+++ b/flink-scala/pom.xml
@@ -146,7 +146,7 @@ under the License.
<scala>
<scalafmt>
<version>${spotless.scalafmt.version}</version>
- <file>../.scalafmt.conf</file>
+ <file>${project.basedir}/../.scalafmt.conf</file>
</scalafmt>
<licenseHeader>
<content>${spotless.license.header}</content>| @@ -1224,12 +1224,12 @@ under the License. | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-source-plugin</artifactId> | |||
| <version>2.2.1</version><!--$NO-MVN-MAN-VER$--> | |||
There was a problem hiding this comment.
is there any particular reason for the upgrade?
There was a problem hiding this comment.
No; it just felt like a good opportunity to do so since we're looking at the plugin anyway.
|
Using |
|
I would use the |
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.