Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29205][connectors/kinesis] Passthrough use config to HTTP clie… #20768

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

dannycranmer
Copy link
Contributor

@dannycranmer dannycranmer commented Sep 6, 2022

…nt when constructing Async Client for Kinesis EFO

What is the purpose of the change

Fix bug introduced in 1.15 where config is not passed through to creation of AWS SDK v2 for EFO, breaking support for custom credential providers.

Brief change log

  • Pass through configuration supplied by user to AWS SDK v2 client

This fix will be applied to 1.15/1.16/1.17:

Verifying this change

  • Unit tested
  • Verified using local application

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? n/a

…nt when constructing Async Client for Kinesis EFO
@flinkbot
Copy link
Collaborator

flinkbot commented Sep 6, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@hlteoh37 hlteoh37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants