[FLINK-29325][documentation]Fix documentation bug on how to enable ba… #20849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myasuka
approved these changes
Sep 16, 2022
mddxhj
force-pushed
the
feature/fix_doc_error
branch
from
f5138a9
to
e455718
Compare
… for streaming examples
mddxhj
force-pushed
the
feature/fix_doc_error
branch
from
e455718
to
6e8cb1b
Compare
|
@flinkbot run azure |
|
The CI on a forked pipeline could pass, and the reason why this CI would fail is due to FLINK-29315. |
Myasuka
requested changes
Sep 20, 2022
There was a problem hiding this comment.
Before merging, I think the kernel idea of this doc is to tell users how to submit jar program with batch execution mode via commands. Current WordCount.jar cannot use such method due to FLINK-24830, however, we should still follow the kernel idea of why this doc exists.
Maybe we can change the line to $ bin/flink run -Dexecution.runtime-mode=BATCH <jarFile>.
What do you think?
… for streaming examples
|
I have update the doc as you said |
|
My forked CI passed: https://dev.azure.com/myasuka/flink/_build/results?buildId=436&view=results |
Myasuka
pushed a commit
that referenced
this pull request
Sep 21, 2022
… for streaming examples This closes #20849.
Myasuka
pushed a commit
that referenced
this pull request
Sep 21, 2022
… for streaming examples This closes #20849.
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
… for streaming examples This closes apache#20849.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix documentation error on how to enable batch mode for streaming examples.
Brief change log
use --execution-mode BATCH instead of -Dexecution.runtime-mode=BATCH
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation