Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29386][hive] Fix fail to compile flink-connector-hive for hive3 #20882

Merged
merged 1 commit into from Sep 26, 2022

Conversation

luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Sep 22, 2022

What is the purpose of the change

To fix fail to compile flink-connector-hive for hive3

Brief change log

  • remove the usable of TableType.INDEX_TABLE and ErrorMsg.SHOW_CREATETABLE_INDEX since they have been removed in Hive3.
  • Port DEFAULT_SERIALIZATION_FORMAT into our own code since DEFAULT_SERIALIZATION_FORMAT exist in different class between Hive2 and Hive3.
  • Fix the test for show create table in Hive3

Verifying this change

The pr run in Hive3 with the commit. The failure isn't related to this fix.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsk119
Copy link
Member

fsk119 commented Sep 26, 2022

The hive connector test in hive3 passes. Merging...

@fsk119 fsk119 merged commit b7b366c into apache:master Sep 26, 2022
luoyuxia added a commit to luoyuxia/flink that referenced this pull request Sep 26, 2022
fsk119 pushed a commit that referenced this pull request Sep 26, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants