Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30852][runtime] Checking task cancelation explicitly rather than failing the cancel method #21833

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

akalash
Copy link
Contributor

@akalash akalash commented Feb 2, 2023

What is the purpose of the change

These changes fix the exception from TestInvokableCorrect#cancel which is 1) incorrect 2) doesn't really fail test

Brief change log

  • Explicit assert for the task cancelation in tests
  • Removed the exception from TestInvokableCorrect#cancel since in some test it isn't correct

Verifying this change

It is test itself

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 2, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@akalash
Copy link
Contributor Author

akalash commented Apr 6, 2023

@rkhachatryan Are you familiar with these tests? May I ask you to take a look at this PR?

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @akalash LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants