Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30852][runtime] Checking task cancelation explicitly rather th… #22436

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

akalash
Copy link
Contributor

@akalash akalash commented Apr 20, 2023

…an failing the cancel method

(cherry picked from commit a6f0165)

What is the purpose of the change

It is backport of #21833

Brief change log

  • Explicit assert for the task cancelation in tests
    
  • Removed the exception from TestInvokableCorrect#cancel since in some test it isn't correct
    

Verifying this change

It's test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…an failing the cancel method

(cherry picked from commit a6f0165)
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 20, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@akalash akalash merged commit aa47c3f into apache:release-1.17 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants