Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32052][table-runtime] Introduce left and right state retention time to StreamingJoinOperator #22566

Closed
wants to merge 2 commits into from

Conversation

LadyForest
Copy link
Contributor

What is the purpose of the change

This is the second subtask for FLIP-292.

Brief change log

This PR introduces leftStateRetentionTime and rightStateRetentionTime to StreamingJoinOperator and StreamingSemiAntiJoinOperator.

Verifying this change

This change added tests and can be verified as follows:

Add StreamingJoinOperatorTest and StreamingSemiAntiJoinOperatorTest to verify the different state TTL for join operators work as expected.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduces a new feature? yes
  • If yes, how is the feature documented? FLINK-31957

@flinkbot
Copy link
Collaborator

flinkbot commented May 11, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@LadyForest
Copy link
Contributor Author

The first failure is not relevant to this change. Well, I've rebased the master n force push to reinvoke CI...

@LadyForest
Copy link
Contributor Author

LadyForest commented May 12, 2023

Hi @lincoln-lil and @godfreyhe, would you mind sparing some time to review it?

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM over all

@LadyForest LadyForest requested a review from godfreyhe May 16, 2023 09:04
@godfreyhe godfreyhe closed this in 5ba3f2b May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants