Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-32052][table-runtime] Introduce left and right state retention time to StreamingJoinOperator #22566

Closed
wants to merge 2 commits into from
Closed

[FLINK-32052][table-runtime] Introduce left and right state retention time to StreamingJoinOperator #22566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9920b
[FLINK-32052][table-runtime] Introduce left and right state retention…
LadyForest Apr 29, 2023
043f32d
address comment.
LadyForest May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...r/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ protected Transformation<RowData> translateToPlanInternal(
leftInputSpec,
rightInputSpec,
joinSpec.getFilterNulls(),
minRetentionTime,
minRetentionTime);
} else {
boolean leftIsOuter = joinType == FlinkJoinType.LEFT || joinType == FlinkJoinType.FULL;
Expand All @@ -199,6 +200,7 @@ protected Transformation<RowData> translateToPlanInternal(
leftIsOuter,
rightIsOuter,
joinSpec.getFilterNulls(),
minRetentionTime,
minRetentionTime);
}

Expand Down
9 changes: 6 additions & 3 deletions ...a/org/apache/flink/table/runtime/operators/join/stream/AbstractStreamingJoinOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ public abstract class AbstractStreamingJoinOperator extends AbstractStreamOperat

private final boolean[] filterNullKeys;

protected final long stateRetentionTime;
protected final long leftStateRetentionTime;
protected final long rightStateRetentionTime;

protected transient JoinConditionWithNullFilters joinCondition;
protected transient TimestampedCollector<RowData> collector;
Expand All @@ -72,13 +73,15 @@ public AbstractStreamingJoinOperator(
JoinInputSideSpec leftInputSideSpec,
JoinInputSideSpec rightInputSideSpec,
boolean[] filterNullKeys,
long stateRetentionTime) {
long leftStateRetentionTime,
long rightStateRetentionTime) {
this.leftType = leftType;
this.rightType = rightType;
this.generatedJoinCondition = generatedJoinCondition;
this.leftInputSideSpec = leftInputSideSpec;
this.rightInputSideSpec = rightInputSideSpec;
this.stateRetentionTime = stateRetentionTime;
this.leftStateRetentionTime = leftStateRetentionTime;
this.rightStateRetentionTime = rightStateRetentionTime;
this.filterNullKeys = filterNullKeys;
}

Expand Down
14 changes: 8 additions & 6 deletions ...main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,17 @@ public StreamingJoinOperator(
boolean leftIsOuter,
boolean rightIsOuter,
boolean[] filterNullKeys,
long stateRetentionTime) {
long leftStateRetentionTime,
long rightStateRetentionTime) {
super(
leftType,
rightType,
generatedJoinCondition,
leftInputSideSpec,
rightInputSideSpec,
filterNullKeys,
stateRetentionTime);
leftStateRetentionTime,
rightStateRetentionTime);
this.leftIsOuter = leftIsOuter;
this.rightIsOuter = rightIsOuter;
}
Expand All @@ -89,15 +91,15 @@ public void open() throws Exception {
"left-records",
leftInputSideSpec,
leftType,
stateRetentionTime);
leftStateRetentionTime);
} else {
this.leftRecordStateView =
JoinRecordStateViews.create(
getRuntimeContext(),
"left-records",
leftInputSideSpec,
leftType,
stateRetentionTime);
leftStateRetentionTime);
}

if (rightIsOuter) {
Expand All @@ -107,15 +109,15 @@ public void open() throws Exception {
"right-records",
rightInputSideSpec,
rightType,
stateRetentionTime);
rightStateRetentionTime);
} else {
this.rightRecordStateView =
JoinRecordStateViews.create(
getRuntimeContext(),
"right-records",
rightInputSideSpec,
rightType,
stateRetentionTime);
rightStateRetentionTime);
}
}

Expand Down
12 changes: 7 additions & 5 deletions ...a/org/apache/flink/table/runtime/operators/join/stream/StreamingSemiAntiJoinOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class StreamingSemiAntiJoinOperator extends AbstractStreamingJoinOperator

private static final long serialVersionUID = -3135772379944924519L;

// true if it is anti join, otherwise is semi joinp
// true if it is anti join, otherwise is semi join
private final boolean isAntiJoin;

// left join state
Expand All @@ -51,15 +51,17 @@ public StreamingSemiAntiJoinOperator(
JoinInputSideSpec leftInputSideSpec,
JoinInputSideSpec rightInputSideSpec,
boolean[] filterNullKeys,
long stateRetentionTime) {
long leftStateRetentionTime,
long rightStateRetentionTIme) {
super(
leftType,
rightType,
generatedJoinCondition,
leftInputSideSpec,
rightInputSideSpec,
filterNullKeys,
stateRetentionTime);
leftStateRetentionTime,
rightStateRetentionTIme);
this.isAntiJoin = isAntiJoin;
}

Expand All @@ -73,15 +75,15 @@ public void open() throws Exception {
LEFT_RECORDS_STATE_NAME,
leftInputSideSpec,
leftType,
stateRetentionTime);
leftStateRetentionTime);

this.rightRecordStateView =
JoinRecordStateViews.create(
getRuntimeContext(),
RIGHT_RECORDS_STATE_NAME,
rightInputSideSpec,
rightType,
stateRetentionTime);
rightStateRetentionTime);
}

/**
Expand Down
Loading