-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-31673][jdbc-driver] Add e2e test for flink jdbc driver #22583
Conversation
95bd05c
to
9835bb4
Compare
@flinkbot run azure |
9835bb4
to
fbcd694
Compare
Hi @libenchao Please have a look at this PR when you are free, thanks |
@FangYongs By saying "e2e test", I mean the tests in |
Thanks @libenchao Sounds good to me, I'll move it there |
fbcd694
to
1c4d68b
Compare
1ccbf49
to
da2db9f
Compare
Hi @libenchao I have update this PR for e2e test, please help to review when you are free, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FangYongs Thanks for your updating, but in 'flink-end-to-end-tests', we usually run these tests via scripts, such as flink-end-to-end-tests/test-scripts/test_batch_sql.sh
, in that way, we'll gain the benefits such as:
- The test will be run as a normal program instead of running in Junit environment, with real flink cluster (local cluster instead of mini cluster)
- These tests will be run in the special stage, not in the maven test stage, which is more flexible
8f57055
to
7d07745
Compare
2541105
to
1e10e79
Compare
62a8cba
to
8ebc924
Compare
Hi @libenchao I have rebased master and updated this PR, please have a look again when you are free, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I only have one minor comment.
@@ -168,7 +168,6 @@ public ShutdownThread(SqlGateway gateway) { | |||
@Override | |||
public void run() { | |||
// Shutdown the gateway | |||
System.out.println("\nShutting down the Flink SqlGateway..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@libenchao Yes, it will cause e2e test failed because the e2e test framework will check the .out
log file and confirm that it is empty. I have confirmed this with @fsk119 that the System.out.println
here is meaningless, we can remove them directly here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me.
What is the purpose of the change
Add e2e test for flink jdbc driver
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no) noDocumentation