Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32300][jdbc-driver] Support get object for result set #22757

Closed

Conversation

FangYongs
Copy link
Contributor

What is the purpose of the change

Support get object for result and support map data

Brief change log

  • Support get object for FlinkResultSet
  • Parse nest map result data
  • Support getUpdataCount for ddl which is used by beeline

Verifying this change

This change added tests and can be verified as follows:

  • Added test case for getObject in FlinkResultSetTest
  • Added test case for getUpdateCount in FlinkStatementTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@FangYongs
Copy link
Contributor Author

@libenchao I have split the main modification from #22583, please help to review this PR when you are free, thanks.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 12, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FangYongs Thanks for your PR, generally looks good, I only left some minor comments.

Besides, what do you think of changing commit message to "Support getObject for FlinkResultSet"?

Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, merging.

@libenchao libenchao closed this in c7afa32 Jun 12, 2023
xiangyuf pushed a commit to xiangyuf/flink that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants