-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33455] Implement restore tests for SortLimit node #23660
Conversation
dca3231
to
1571646
Compare
...src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java
Outdated
Show resolved
Hide resolved
1571646
to
ef6cc44
Compare
@flinkbot run azure |
...src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java
Outdated
Show resolved
Hide resolved
One more thing I just noticed (actually it's also a problem for Calc tests) that we should not put those classes/tests in I don't have a concrete proposal yet, but we should think of a better structure. |
Can we reuse |
Yes, let's do that |
Should the Programs and Tests go into separate packages? |
For the time being lets keep them in the same package so that we don't overcompilcate things. |
f8c58db
to
6504360
Compare
6504360
to
3cd03e2
Compare
3cd03e2
to
3370d6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Looks really good!
What is the purpose of the change
Implement restore tests for SortLimit node
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation