[FLINK-33469] Implement restore tests for Limit node #23675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnh5y
force-pushed
the
FLINK-33469
branch
3 times, most recently
from
e8a439c to
942467b
Compare
dawidwys
reviewed
Nov 8, 2023
| .setupTableSink( | ||
| SinkTestStep.newBuilder("sink_t") | ||
| .addSchema("a INT", "b VARCHAR", "c BIGINT") | ||
| .addOption("sink-insert-only", "false") |
There was a problem hiding this comment.
This is set by the RestoreTestBase
Comment on lines
44
to
45
| .producedBeforeRestore(DATA) | ||
| .producedAfterRestore(DATA) |
There was a problem hiding this comment.
I'd vote for not having such patterns. See #23660 (comment)
| + " 'table-sink-class' = 'DEFAULT')"; | ||
| tEnv.executeSql(sinkTableDdl); | ||
| String sql = "insert into MySink SELECT a, a from MyTable limit 10"; | ||
| util.verifyJsonPlan(sql); |
There was a problem hiding this comment.
It uses a checked in plan file, doesn't it? Can we remove it as well?
|
Responded to comments and moved the new tests to the package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Implement restore tests for Limit node
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation