Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32721][table-planner] Fix SQL MAX aggregation function does no… #23671

Closed
wants to merge 1 commit into from

Conversation

paul8263
Copy link
Contributor

@paul8263 paul8263 commented Nov 6, 2023

…t support CHAR type

What is the purpose of the change

Support max aggregation with char data type by reusing the existing MaxAggFunction.

Brief change log

Files updated:

  • flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala

Verifying this change

This change is covered in existing unit test and manual test. Please see also FLINK-32721

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 6, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@lsyldliu
Copy link
Contributor

@paul8263 Thanks for your contribution, this will be fixed by #18375, this pr will be closed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants