-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25476][table-planner] support CHAR type in function MAX and MIN #18375
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6436e2a (Mon Jan 17 05:51:52 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM: the implementation is straightforward, and it seems logical that if VARCHAR is supported for MIN/MAX aggregations, CHAR could be as well.
6436e2a
to
7a43b00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuyangzhong Thanks for your contribution, LGTM overall, I just left a minor comment.
What is the purpose of the change
Now function MAX and MIN does not support the type CHAR and will throw the exception like following:
Caused by: org.apache.flink.table.api.TableException: Max aggregate function does not support type: ''CHAR''. Please re-check the data type. at org.apache.flink.table.planner.plan.utils.AggFunctionFactory.createMaxAggFunction(AggFunctionFactory.scala:395) at org.apache.flink.table.planner.plan.utils.AggFunctionFactory.createAggFunction(AggFunctionFactory.scala:76) at org.apache.flink.table.planner.plan.utils.AggregateUtil$.$anonfun$transformToAggregateInfoList$1(AggregateUtil.scala:444)
This pr aims to add the support in MAX and MIN with both retract and non-retract stream data.
Brief change log
Verifying this change
Some test cases are added to verify this change.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation