Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-32721] [planner] Support CharType for the MaxAggFunction #23943

Closed

Conversation

liuyongvs
Copy link
Contributor

What is the purpose of the change

Support CharType for the MaxAggFunction.*

Brief change log

  • Support CharType for the MaxAggFunction like MinAggFunction*

Verifying this change

  • original unit test *

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 18, 2023

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@lsyldliu
Copy link
Contributor

@liuyongvs Thanks for your contribution, this will be fixed by #18375, this pr will be closed later.

@liuyongvs
Copy link
Contributor Author

@liuyongvs Thanks for your contribution, this will be fixed by #18375, this pr will be closed later.

@lsyldliu thanks for your clarify, i also add comments for the pr you refer

@liuyongvs
Copy link
Contributor Author

liuyongvs commented Dec 20, 2023

i close it now @lsyldliu @xuyangzhong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants