Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33221][core][config] Add config options for administrator JVM options #24098

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

X-czh
Copy link
Contributor

@X-czh X-czh commented Jan 15, 2024

What is the purpose of the change

Add config options for administrator JVM options.

Brief change log

  1. Added three config options: env.java.default-opts.all, env.java.default-opts.jobmanager env.java.default-opts.taskmanager that prepends to the corresponding non-default options.
  2. For non-YARN envs, directly assemble the JVM opts in shell command.
  3. For YARN env, change BootstrapTools#getTaskManagerShellCommand & YarnClusterDescriptor acccordingly.

Verifying this change

  • The non-YARN related change is tested by starting local standalone clusters & K8s clusters and manually verify the JVM opts.
  • The YARN-related change is covered by UT.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) yes
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) docs

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 15, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@X-czh
Copy link
Contributor Author

X-czh commented Jan 16, 2024

Hi @huwh @1996fanrui, do you have time to help review this?

@1996fanrui 1996fanrui self-requested a review January 16, 2024 05:46
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @X-czh for the contribution!

Overall LGTM, I left some minor comments, please take a look in your free time, thanks~

@X-czh
Copy link
Contributor Author

X-czh commented Jan 17, 2024

Thanks for the quick review @1996fanrui. I've updated the PR accordingly

@1996fanrui
Copy link
Member

Hi @X-czh , #24089 is merged, please go ahead, thanks~

Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @X-czh for the update, LGTM.

@1996fanrui 1996fanrui merged commit b4eb8ac into apache:master Jan 22, 2024
@X-czh X-czh deleted the FLINK-33221 branch January 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants