-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33221][core][config] Add config options for administrator JVM options #24098
Conversation
Hi @huwh @1996fanrui, do you have time to help review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @X-czh for the contribution!
Overall LGTM, I left some minor comments, please take a look in your free time, thanks~
flink-core/src/main/java/org/apache/flink/configuration/CoreOptions.java
Outdated
Show resolved
Hide resolved
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
Outdated
Show resolved
Hide resolved
Thanks for the quick review @1996fanrui. I've updated the PR accordingly |
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @X-czh for the update, LGTM.
What is the purpose of the change
Add config options for administrator JVM options.
Brief change log
env.java.default-opts.all
,env.java.default-opts.jobmanager
env.java.default-opts.taskmanager
that prepends to the corresponding non-default options.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no) noDocumentation