[FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants#24089
Merged
1996fanrui merged 2 commits intoapache:masterfrom Jan 19, 2024
Merged
Conversation
Collaborator
adac29f to
b6e61ef
Compare
Contributor
Author
|
@1996fanrui @xintongsong Could you review this PR? |
1996fanrui
approved these changes
Jan 17, 2024
Member
1996fanrui
left a comment
There was a problem hiding this comment.
Thanks @Sxnan for the contribution!
I left 2 minor comments, please take a look in your free time.
BTW, IIUC the first commit is a refactor without any real change, right? If so, it's better to add [refactor] in the commit message. It's helpful for understand these commit, thanks~
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
Show resolved
Hide resolved
…Command to flink-yarn Utils
…constants in ConfigConstants
Contributor
Author
|
@flinkbot run azure |
1 similar comment
Member
|
@flinkbot run azure |
Member
|
The CI is green, merging~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR updates ConfigConstants.java to deprecate and replace string configuration keys and marks unused constants in ConfigConstants.java as deprecated.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation