Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-1.19][FLINK-34274][runtime] Implicitly disable resource wait timeout for AdaptiveSchedulerTest #24400

Merged
merged 2 commits into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. [FLINK-34274][runtime] Implicitly disable resource wait timeout for A…

    …daptiveSchedulerTest.
    dmvk authored and XComp committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    49f91a1 View commit details
    Browse the repository at this point in the history
  2. Fixes test: The comment is obsolete (because we're not using the reso…

    …urceWaitTimeout anymore) and just adds confusion because we don't need to wait in this test:
    
    0. The mentioned test method #testRequirementLowerBoundIncreaseBeyondCurrentParallelismAttemptsImmediateRescale does not exist (#testRequirementLowerBoundIncreaseBeyondCurrentParallelismKeepsJobRunning is most likely meant)
    1. the startJobWithSlotsMatchingParallelism will be executed in the main thread and, therefore, finishes before updateJobResourceRequirements is triggered (which also runs in the main thread)
    2. Running both calls in the main thread ensures sequential execution of the commands with the scheduler being in WaitingForResources state when calling updateJobResourceRequirements
    XComp committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1f77939 View commit details
    Browse the repository at this point in the history