Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34897][test] Enables JobMasterServiceLeadershipRunnerTest#testJobMasterServiceLeadershipRunnerCloseWhenElectionServiceGrantLeaderShip again. #24546

Merged
merged 1 commit into from Mar 27, 2024

Conversation

XComp
Copy link
Contributor

@XComp XComp commented Mar 20, 2024

PR Chain

What is the purpose of the change

It seems like I disabled the test accidentally with FLINK-31783. This PR re-enables the test (and fixes it).

Brief change log

  • Enables test again
  • Makes the test wait for the leadership being confirmed by polling the leader information in the HA backend rather than relying on hasLeadership

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@XComp XComp changed the title [FLINK-34897][test] Enables JobMasterServiceLeadershipRunnerTest#test… [FLINK-34897][test] Enables JobMasterServiceLeadershipRunnerTest#testJobMasterServiceLeadershipRunnerCloseWhenElectionServiceGrantLeaderShip again. Mar 20, 2024
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 20, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

…JobMasterServiceLeadershipRunnerCloseWhenElectionServiceGrantLeaderShip again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants