[FLINK-35423][table] ARRAY_EXCEPT should follow set semantics #24828
Conversation
|
Hi @snuyanzin, what is the state of this PR right now? I notice this as it marked as a blocker of 1.20. |
|
hi @reswqa thanks for reaching out now just need to wait and then need for a reviewer |
docs/data/sql_functions.yml
Outdated
| @@ -687,7 +687,7 @@ collection: | |||
| description: Returns a map created from an arrays of keys and values. Note that the lengths of two arrays should be the same. | |||
| - sql: ARRAY_EXCEPT(array1, array2) | |||
| table: arrayOne.arrayExcept(arrayTwo) | |||
| description: Returns an ARRAY that contains the elements from array1 that are not in array2. If no elements remain after excluding the elements in array2 from array1, the function returns an empty ARRAY. If one or both arguments are NULL, the function returns NULL. The order of the elements from array1 is kept. | |||
| description: Returns an ARRAY that contains the elements from array1 that are not in array2. If no elements remain after excluding the elements in array2 from array1, the function returns an empty ARRAY. If one or both arguments are NULL, the function returns NULL. The order of the elements from array1 is kept however the duplicates are removed. | |||
There was a problem hiding this comment.
nit: what about following the format with 'ARRAY_UNION'?
Returns an ARRAY that contains the elements from array1 that are not in array2, without duplicates.
...
There was a problem hiding this comment.
yep, that looks more concise and easier to read
There was a problem hiding this comment.
Sorry, perhaps I haven't made myself clear, I want to keep the latter part the same.
Returns an ARRAY that contains the elements from array1 that are not in array2, without duplicates. If no elements remain after excluding the elements in array2 from array1, the function returns an empty ARRAY. If one or both arguments are NULL, the function returns NULL. The order of the elements from array1 is kept.
|
rebased to solve the conflicts thanks for the review, once it's green I will merge it |
docs/data/sql_functions_zh.yml
Outdated
| @@ -817,6 +817,12 @@ collection: | |||
| - sql: MAP_UNION(map1, map2) | |||
| table: map1.mapUnion(map2) | |||
| description: 返回一个通过合并两个图 'map1' 和 'map2' 创建的图。这两个图应该具有共同的图类型。如果有重叠的键，'map2' 的值将覆盖 'map1' 的值。如果任一图为空，则返回 null。 | |||
| - sql: ARRAY_EXCEPT(array1, array2) | |||
| table: arrayOne.arrayExcept(arrayTwo) | |||
There was a problem hiding this comment.
nit: may put it to arrays function better
|
LGTM, only left minor comments. and arrays function put them together and ordered by name may be better |
|
Thanks for taking a look |
What is the purpose of the change
The idea of the PR is making of
ARRAY_EXCEPTfollowing set semanticsBrief change log
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayExceptFunction.java
Verifying this change
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation