Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36013] [runtime] Introduce the transition from Restarting to CreatingExecutionGraph state #25313

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

ztison
Copy link
Contributor

@ztison ztison commented Sep 11, 2024

What is the purpose of the change

The AdaptiveScheduler omits the WaitingForResources state when rescaling to avoid an additional waiting in that state.

Brief change log

  • Pass the forcedRestart flag into the Restarting state
  • Directs the state transition to the CreatingExecutingGraph instead of WaitingForResources if flag forcedRestart is set

Verifying this change

This change added tests and can be verified as follows:

  • Added test to verify final state transition if the flag is set or not

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 11, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor

XComp commented Sep 12, 2024

Follow-up PR after PR #25304 was closed "accidentally".

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@XComp XComp merged commit 77da041 into apache:master Sep 12, 2024
@XComp XComp deleted the flink-36013 branch September 12, 2024 08:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants