[FLINK-5135][JM]ResourceProfile for slot request should be expanded to correspond with ResourceSpec #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 28, 2016 18:10
… Fine-grained Resource Configuration Summary: above Test Plan: NA Reviewers: yushi.wxg Subscribers: #blink Differential Revision: http://phabricator.taobao.net/D6593
…PI for DataSet and DataStream
…PI for DataSet and DataStream
…PI for DataSet and DataStream
…o correspond with ResourceSpec
… Fine-grained Resource Configuration
… Fine-grained Resource Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ResourceProfile only contains cpu cores and memory properties. The memory should be expanded to different types such as heap memory, direct memory and native memory which corresponds with memory in ResourceSpec.
It contains the related un-merging codes for [FLINK-5132] [FLINK-5133] [FLINK-5134]. And the modifications for [FLINK-5135] only includes SlotPool and ResourceProfile.