-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flink-4450 update storm version to 1.0 #3037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One minor question, then we can merge this.
Utils.sleep(100); | ||
} | ||
cluster.shutdown(); | ||
// LocalCluster cluster = new LocalCluster(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these lines accidentally commented out, or is this not working with Storm 1.0 any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes , It can't work with Strom 1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an alternative way to do this, or is there no local cluster in Storm 1.0 any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local Cluster still work in Storm post 1.0, but It can't work in this version by this code, and I didn't find the solution.
How about I solve it later in new pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's okay. Can you open a JIRA issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I open new issue in FLINK-5522
The reason is: Local Cluster can't run with powermock.
Discussions have been resolved, thanks! Merging this... |
@StephanEwen @mxm
The old pull request #2439 was wrong , I use this account make a new pull request.
Please me to review this pull request.
Storm example Test: