Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink-4450 update storm version to 1.0 #3037

Closed
wants to merge 3 commits into from

Conversation

liuyuzhong7
Copy link
Contributor

@StephanEwen @mxm
The old pull request #2439 was wrong , I use this account make a new pull request.

Please me to review this pull request.

Storm example Test:
image

Copy link
Contributor

@StephanEwen StephanEwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One minor question, then we can merge this.

Utils.sleep(100);
}
cluster.shutdown();
// LocalCluster cluster = new LocalCluster();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these lines accidentally commented out, or is this not working with Storm 1.0 any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , It can't work with Strom 1.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an alternative way to do this, or is there no local cluster in Storm 1.0 any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local Cluster still work in Storm post 1.0, but It can't work in this version by this code, and I didn't find the solution.

How about I solve it later in new pull request?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay. Can you open a JIRA issue for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I open new issue in FLINK-5522

The reason is: Local Cluster can't run with powermock.

@StephanEwen
Copy link
Contributor

Discussions have been resolved, thanks!

Merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Jan 16, 2017
@asfgit asfgit closed this in 475c0b1 Jan 16, 2017
@liuyuzhong7 liuyuzhong7 deleted the FLINK-4450 branch February 9, 2017 06:04
joseprupi pushed a commit to joseprupi/flink that referenced this pull request Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants