[FLINK-6293] [tests] Harden JobManagerITCase #3796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the unit tests in JobManagerITCase starts a MiniCluster and sends a LeaderSessionMessage to the JobManager without waiting until the JobManager has gained leadership. This can lead to a dropped TriggerSavepoint message which will cause the test to deadlock. This PR fixes the problem by explicitly waiting for the JobManager to become the leader.
|
Good fix. +1 to merge. |
|
Thanks for the review @uce. Merging this PR. |
fanyon
pushed a commit
to fanyon/flink
that referenced
this pull request
May 11, 2017
One of the unit tests in JobManagerITCase starts a MiniCluster and sends a LeaderSessionMessage to the JobManager without waiting until the JobManager has gained leadership. This can lead to a dropped TriggerSavepoint message which will cause the test to deadlock. This PR fixes the problem by explicitly waiting for the JobManager to become the leader. This closes apache#3796.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the unit tests in JobManagerITCase starts a MiniCluster and sends a
LeaderSessionMessage to the JobManager without waiting until the JobManager
has gained leadership. This can lead to a dropped TriggerSavepoint message
which will cause the test to deadlock.
This PR fixes the problem by explicitly waiting for the JobManager to become
the leader.