Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6476] - Table environment register row data stream #3847

Closed
wants to merge 1 commit into from

Conversation

rtudoran
Copy link
Contributor

@rtudoran rtudoran commented May 8, 2017

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • [x ] General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • [x ] Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • [x ] Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@rtudoran
Copy link
Contributor Author

rtudoran commented May 8, 2017

@fhueske

Please have a look. I inserted tests in scala and java to check the registration of the stream.
For scala - it seemed to work directly if the implicit value is set (i did not know to test this before opening the JIRA).
For java - i have added the needed support in TableEnvironment.

it is not much...i hope i did not miss anything

(I closed the previous PR as by mistake i pushed also an intermediate commit )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants