Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6667] Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph #4277

Closed
wants to merge 1 commit into from

Conversation

FangYongs
Copy link
Contributor

… the full ExecutionGraph

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@FangYongs
Copy link
Contributor Author

@StephanEwen @tillrohrmann As discussed in #4220, I create this PR to fix issue FLINK-6667. Could you please have a look when you're free, thanks :)

@StephanEwen
Copy link
Contributor

@zjureel Thanks for this patch. I will pick it up from here.
I think there is a small additional change needed, and a test, but I can do that...

@FangYongs
Copy link
Contributor Author

Thank you for your reply, I will fix FLINK-6665 after this PR is merged, thanks :)

@StephanEwen
Copy link
Contributor

I have taken and adapted the code for the patch in #4364

@StephanEwen
Copy link
Contributor

Thank you for the contribution!
The code form this PR has been improved and merged in this commit: 65400bd

If you agree, could you close this PR?

@FangYongs
Copy link
Contributor Author

Thank you for your merging, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants