[FLINK-7350] [travis] Only execute japicmp in misc profile #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we upgrade to japicmp 0.10 or delay this change until such time? |
|
I tried upgrading the plugin, but then more violations were detected causing the build to fail. I didn't have the time to properly investigate whether it makes sense to upgrade the plugin now or not. The nice thing is that if we ever decide to upgrade it later on we only have to remove the profile that i add, the travis scripts will work as is. |
greghogan
reviewed
Aug 2, 2017
| MVN_COMPILE_OPTIONS="$MVN_COMPILE_OPTIONS -DskipTests" | ||
|
|
||
| MVN_COMPILE="mvn $MVN_COMMON_OPTIONS $MVN_COMPILE_OPTIONS $PROFILE $MVN_COMPILE_MODULES clean install" | ||
| MVN_TEST="mvn -$MVN_COMMON_OPTIONS $PROFILE $MVN_TEST_MODULES verify" |
There was a problem hiding this comment.
Looks to be a spurious - after mvn.
There was a problem hiding this comment.
I've removed it in #4460.
|
@greghogan That's a great idea, implemented it. |
|
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4460.
What is the purpose of the change
Improve travis build times and stability by skipping redundant japicmp executions.
Note that the japicmp 0.7 does not allow skipping the execution form the command-line (only added in 0.10), so I worked around that with a profile that is activated by specifying
-Djapicmp.skip=true, which is how it would work in 0.10.Brief change log
japicmp.skipproperty to skip executionskip-japicmpprofile to skip execution, activated by specifying "-Djapicmp.skip=true"-Djapicmp.skip=trueto core/libraries/connector/tests profile optionsVerifying this change
Remove the
@Publicannotation from any class and run it on travis, should only fail 1 profile (i.e. 2 builds)Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation