New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-7806] [flip6] Register CurrentJobsOverviewHandler under /jobs #4805
[FLINK-7806] [flip6] Register CurrentJobsOverviewHandler under /jobs #4805
Conversation
2a9c951
to
b5f670d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the vendor.js and vendor.css files should not change; otherwise +1-
Not sure why the changed @zentol. I just executed the build process as it was described in the readme. |
59a21af
to
2d41896
Compare
Often happens due to different dependency/build system versions of even OS specific oddities. I typically just revert those changes. |
Alright. I'm wondering whether it would be possible to somehow fix these things because this is bound to be changed. |
2d41896
to
cfd5bbc
Compare
I reverted the changes to |
I'm not entirely sure, but I think we cannot put the So either we don't do this change or we register the handler under |
let's put iut under /jobs then for now. |
Alright, I'll change the PR. |
05fa39c
to
252a0d8
Compare
252a0d8
to
6de4a0f
Compare
Rebased onto the latest master. Once Travis gives green light, I'll merge this PR. |
16e66a2
to
908363e
Compare
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
HandlerUtils#sendResponse now accepts a map of additional http response headers and their values. This allows to set additional headers such as the ACCESS_CONTROL_ALLOW_ORIGIN header and its value. This closes apache#4859.
Send dataPort and HardwareDescription to RM Instantiate RM leader retriever
…y.TaskManagersHandler This closes apache#4824.
…sages to rest.messages.taskmanager Move TaskManager messages to rest.messages.taskmanager Move TaskManager message tests to rest.messages.taskmanager
Pass MetricQueryServiceRetriever to DispatcherRestEndpoint This closes apache#4862.
… array Fix failing WebFrontendITCase
Add JobID(De)Serializer and JobVertexID(De)Serializer for jackson This closes apache#4884.
b932049
to
5836df8
Compare
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes apache#4805.
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes apache#4805.
5836df8
to
0d1114f
Compare
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes apache#4805.
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes apache#4805.
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes #4805.
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes apache#4805.
What is the purpose of the change
This PR changes the REST endpoint URL of the
CurrentJobsOverviewHandler
from/joboverview
to/jobs/overview
. Moreover, it renames the handler toJobsOverviewHandler
.Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation