-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-7914] Introduce AkkaOptions.RETRY_GATE_CLOSED_FOR #4903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-7914] Introduce AkkaOptions.RETRY_GATE_CLOSED_FOR #4903
Conversation
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms.
f14f100 to
a25a6dd
Compare
|
Change looks good. |
|
Akka's default value is actually 5 seconds, which I think is a bit too high. I actually tried to backtrack an instability in the The actual solution to speed up this test was then to don't reuse the same port for the new JobManager system, but I couldn't think of a good reason to keep the 5 seconds default. Moreover, some other tests which also run into the case of gated connections could also benefit from that. I think lowering the gated interval should allow us to reestablish a lost connection faster. However, I wasn't able to reproduce the test instability I've seen on Travis wrt |
|
Sounds fair, +1 |
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
What is the purpose of the change
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote
ActorSystem is gated in case of a connection loss. The default value is set
to 50 ms.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation