[FLINK-8087] Decouple Slot from AllocatedSlot #5088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
decoupleSlotFromSlotPool
branch
from
84d86be
to
e3f9150
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 1, 2017
This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the relevant slot information to do the communication with the TaskManager without relying on the AllocatedSlot which is now only used by the SlotPool. This closes apache#5088.
tillrohrmann
force-pushed
the
decoupleSlotFromSlotPool
branch
from
e3f9150
to
dd139a4
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 1, 2017
This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the relevant slot information to do the communication with the TaskManager without relying on the AllocatedSlot which is now only used by the SlotPool. This closes apache#5088.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 3, 2017
This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the relevant slot information to do the communication with the TaskManager without relying on the AllocatedSlot which is now only used by the SlotPool. This closes apache#5088.
GJL
reviewed
Dec 6, 2017
| @@ -31,7 +30,7 @@ | |||
| import static org.mockito.Mockito.mock; | |||
| import static org.mockito.Mockito.when; | |||
|
|
|||
| public class AllocatedSlotsTest { | |||
| public class SlotsTestImplContext { | |||
There was a problem hiding this comment.
This is a mistake. Will correct it.
GJL
reviewed
Dec 6, 2017
| * <p> | ||
| * This method should be removed once the new interface-based RPC abstraction is in place | ||
| * | ||
| * @return The actor gateway that can be used to send messages to the TaskManager. |
There was a problem hiding this comment.
The fact that TaskManagerGateway can be an actor gateway is not something that is relevant for the reader of the Javadoc.
There was a problem hiding this comment.
Will remove it.
GJL
reviewed
Dec 6, 2017
| @@ -312,24 +312,36 @@ public void returnAllocatedSlot(Slot slot) { | |||
| // (1) do we have a slot available already? | |||
| SlotAndLocality slotFromPool = availableSlots.poll(resources, locationPreferences); | |||
| if (slotFromPool != null) { | |||
| SimpleSlot slot = createSimpleSlot(slotFromPool.slot(), slotFromPool.locality()); | |||
There was a problem hiding this comment.
Method createSimpleSlot is no longer in use and can be deleted.
There was a problem hiding this comment.
True. Will do it.
GJL
reviewed
Dec 6, 2017
| return true; | ||
| } | ||
| } else { | ||
| throw new RuntimeException("Unsupported logical slot type encounterd " + logicalSlot.getClass()); |
There was a problem hiding this comment.
Good catch. Will correct it.
The cluster entrypoints start the ResourceManager with the web interface URL. This URL is used to set the correct tracking URL in Yarn when registering the Yarn application. This closes apache#5128.
This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the relevant slot information to do the communication with the TaskManager without relying on the AllocatedSlot which is now only used by the SlotPool. This closes apache#5088.
tillrohrmann
force-pushed
the
decoupleSlotFromSlotPool
branch
from
dd139a4
to
0945d9e
Compare
|
Thanks for the review @GJL. Merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit introduces the SlotContext which is an abstraction for the SimpleSlot
to obtain the relevant slot information to do the communication with the
TaskManager without relying on the AllocatedSlot which is now only used by the
SlotPool.
This PR is based on #5087.
Brief change log
SlotContextas simple abstraction for slot related informationSlotonAllocatedSlotwhich is now only used internally by theSlotPool.SimpleSlotContextwhich implementsSlotContextand acts as the slot context for theSimpleSlot.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
CC: @GJL