[FLINK-8088] Associate logical slots with the slot request id #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
slotAssociation
branch
from
80a3cc8
to
fb50caa
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 1, 2017
Before logical slots like the SimpleSlot and SharedSlot where associated to the actually allocated slot via the AllocationID. This, however, was sub-optimal because allocated slots can be re-used to fulfill also other slot requests (logical slots). Therefore, we should bind the logical slots to the right id with the right lifecycle which is the slot request id. This closes apache#5089.
tillrohrmann
force-pushed
the
slotAssociation
branch
from
fb50caa
to
6c632cc
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 1, 2017
Before logical slots like the SimpleSlot and SharedSlot where associated to the actually allocated slot via the AllocationID. This, however, was sub-optimal because allocated slots can be re-used to fulfill also other slot requests (logical slots). Therefore, we should bind the logical slots to the right id with the right lifecycle which is the slot request id. This closes apache#5089.
tillrohrmann
force-pushed
the
slotAssociation
branch
from
6c632cc
to
d75305b
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 1, 2017
Before logical slots like the SimpleSlot and SharedSlot where associated to the actually allocated slot via the AllocationID. This, however, was sub-optimal because allocated slots can be re-used to fulfill also other slot requests (logical slots). Therefore, we should bind the logical slots to the right id with the right lifecycle which is the slot request id. This closes apache#5089.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Dec 3, 2017
Before logical slots like the SimpleSlot and SharedSlot where associated to the actually allocated slot via the AllocationID. This, however, was sub-optimal because allocated slots can be re-used to fulfill also other slot requests (logical slots). Therefore, we should bind the logical slots to the right id with the right lifecycle which is the slot request id. This closes apache#5089.
The cluster entrypoints start the ResourceManager with the web interface URL. This URL is used to set the correct tracking URL in Yarn when registering the Yarn application. This closes apache#5128.
This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the relevant slot information to do the communication with the TaskManager without relying on the AllocatedSlot which is now only used by the SlotPool. This closes apache#5088.
Before logical slots like the SimpleSlot and SharedSlot where associated to the actually allocated slot via the AllocationID. This, however, was sub-optimal because allocated slots can be re-used to fulfill also other slot requests (logical slots). Therefore, we should bind the logical slots to the right id with the right lifecycle which is the slot request id. This closes apache#5089.
tillrohrmann
force-pushed
the
slotAssociation
branch
from
d75305b
to
254aebb
Compare
|
Merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Before, logical slots like the
SimpleSlotandSharedSlotwhere associated to theactually allocated slot via the
AllocationID. This, however, was sub-optimal becauseallocated slots can be re-used to fulfill also other slot requests (logical slots).
Therefore, we should bind the logical slots to the right id with the right lifecycle
which is the
SlotRequestID.This PR is based on #5088.
Brief change log
SlotRequestIDSlotRequestIDwhich is valid over the lifetime of a logical slotDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
CC: @GJL