[FLINK-8748] [flip6] Cancel slot allocations for alternatively completed slot requests #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
slotPoolCancelSlotRequests
branch
5 times, most recently
from
2aa2e86
to
efc5440
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 24, 2018
…ted slot requests If a slot request is fulfilled with a different AllocatedSlot in the SlotPool, then we cancel the slot request sent to the ResourceManager. This closes apache#5561.
This commit enables the rescaling of Flink jobs which are currently not fully deployed. In such a case, Flink will use the last internal rescaling savepoint. If there is no such savepoint, then it will use the provided savepoint when the job was submitted. In case that there is no savepoint at all, then it will restart the job with vanilla state. This closes apache#5560.
The problem was a race condition between the triggerCheckpoint and the wait loop which had as termination condition the number of received trigger checkpoint messages.
…ted slot requests If a slot request is fulfilled with a different AllocatedSlot in the SlotPool, then we cancel the slot request sent to the ResourceManager. This closes apache#5561.
tillrohrmann
force-pushed
the
slotPoolCancelSlotRequests
branch
from
efc5440
to
529b512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If a slot request is fulfilled with a different AllocatedSlot in the SlotPool,
then we cancel the slot request sent to the ResourceManager.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation