[FLINK-8814] Control over the extension of part files created by BucketingSink #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles created by BucketingSink.
aljoscha
approved these changes
Mar 1, 2018
| @@ -986,6 +996,14 @@ private void handlePendingFilesForPreviousCheckpoints(Map<Long, List<String>> pe | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the prefix of part files. The default is no suffix. | |||
|
Merged. 👍 Could you please close the PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Popular tools like hue and the avro connector for spark require files stored on hdfs to have the .avro extension. This patch makes it possible to configure a part file suffix
Brief change log
Verifying this change
The basic functionality of BucketingSink is verified by BucketingSinkTest. The structure of this test makes it awkward to test this in isolation
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation