Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-8783] [tests] Harden SlotPoolRpcTest #5684

Closed
wants to merge 1 commit into from
Closed

[FLINK-8783] [tests] Harden SlotPoolRpcTest #5684

wants to merge 1 commit into from

Conversation

tillrohrmann
Copy link
Contributor

What is the purpose of the change

Wait for releasing of timed out pending slot requests before checking the
number of pending slots requests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@tillrohrmann
[FLINK-8783] [tests] Harden SlotPoolRpcTest
5f3e1a4 
Wait for releasing of timed out pending slot requests before checking the
number of pending slots requests.
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @GJL. Merging this PR.

asfgit pushed a commit that referenced this pull request Mar 13, 2018
@tillrohrmann
[FLINK-8783] [tests] Harden SlotPoolRpcTest
afac526 
Wait for releasing of timed out pending slot requests before checking the
number of pending slots requests.

This closes #5684.
@asfgit asfgit closed this in 2d19d11 Mar 13, 2018
@tillrohrmann tillrohrmann deleted the hardenSlotPoolRpcTest branch March 13, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GJL GJL GJL approved these changes

Assignees
No one assigned
Labels
component=Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tillrohrmann @GJL @rmetzger