Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8990] [test] Extend Kafka end-to-end test to verify partition discovery #5779

Closed
wants to merge 3 commits into from

Conversation

tzulitai
Copy link
Contributor

What is the purpose of the change

This PR is based on #5778.

The changes further extends the Kafka end-to-end tests to cover verifying the partition discovery feature.

Brief change log

The whole test now does the following:

  • Start of with 1 partition for the test topic
  • Writes some messages, and then verify output
  • Add a new partition to the test topic
  • Verify that a new partition is really added to the topic
  • Writes some more messages
  • Verify that we really do have some messages in the new partition
  • Verify new output

Verifying this change

This PR is an extension to existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@aljoscha
Copy link
Contributor

The changes look good to merge! 👍

@tzulitai
Copy link
Contributor Author

Thanks for the review @aljoscha.
Merging this ...

tzulitai added a commit to tzulitai/flink that referenced this pull request Apr 18, 2018
asfgit pushed a commit that referenced this pull request Apr 18, 2018
@asfgit asfgit closed this in e77f9d2 Apr 18, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants