[FLINK-9179] [conf] Fix deduplicate WebOptions.PORT and RestOptions.PORT #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rice668
commented
Apr 16, 2018
| @@ -38,7 +38,10 @@ | |||
|
|
|||
| /** | |||
| * The port for the runtime monitor web-frontend server. | |||
| * | |||
| * @deprecated Use {@link RestOptions#PORT} instead | |||
| */ | |||
There was a problem hiding this comment.
FLINK-9180 rename it to RestOptions#PORT.
|
Hi @zentol This patch is ready for having a review. |
|
we should also update |
|
there are also other references: classes:
docs:
scripts:
|
|
Thanks for @zentol having an awesome review! Will have a update soon. |
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 25, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 25, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 30, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 30, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
May 9, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
May 9, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
May 9, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
May 9, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
May 10, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
There are deduplicate WebOptions.PORT and RestOptions.REST_PORT. Should be solved.
Brief change log
Deprecate WebOptions.PORT, and add a deprecated key to RestOptions.REST_PORT.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.