[FLINK-9196][flip6, yarn] Cleanup application files when deregistering YARN AM #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GJL
commented
Apr 28, 2018
|
|
||
| /** | ||
| * Tests for {@link Utils}. | ||
| */ | ||
| public class UtilsTest extends TestLogger { |
There was a problem hiding this comment.
Renamed class to YarnFlinkResourceManagerTest.
GJL
commented
Apr 28, 2018
|
|
||
| /** | ||
| * Tests for {@link Utils}. | ||
| */ | ||
| public class UtilsTest extends TestLogger { | ||
| public class UtilsTest { |
GJL
commented
Apr 28, 2018
| LOG.info("Sending shutdown request to the Application Master"); | ||
| try { | ||
| final Future<Object> response = Patterns.ask(applicationClient.get(), | ||
| new YarnMessages.LocalStopYarnSession(ApplicationStatus.SUCCEEDED, |
There was a problem hiding this comment.
Always SUCCEEDED because previous logic in 1.4.2 used
YarnApplicationState appState = lastReport.getYarnApplicationState();
ApplicationStatus status =
(appState == YarnApplicationState.FAILED || appState == YarnApplicationState.KILLED) ?
ApplicationStatus.FAILED : ApplicationStatus.SUCCEEDED;
if (status != ApplicationStatus.SUCCEEDED) {
LOG.warn("YARN reported application state {}", appState);
LOG.warn("Diagnostics: {}", lastReport.getDiagnostics());
}
return status;
which does not make sense imo.
Test was misnamed.
…g YARN AM Enable graceful cluster shut down via HTTP. Remove Flink application files from remote file system when the YarnResourceManager deregisters the YARN ApplicationMaster.
StephanEwen
approved these changes
Apr 30, 2018
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| } catch (ExecutionException e) { | ||
| log.error("Error while shutting down cluster", e); |
There was a problem hiding this comment.
Throw the cause of the ExecutionException?
|
Merging this... |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Apr 30, 2018
…ng YARN AM Enable graceful cluster shut down via HTTP. Remove Flink application files from remote file system when the YarnResourceManager deregisters the YARN ApplicationMaster. This closes apache#5938
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…ng YARN AM Enable graceful cluster shut down via HTTP. Remove Flink application files from remote file system when the YarnResourceManager deregisters the YARN ApplicationMaster. This closes apache#5938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Ensure that YARN application files are removed if cluster is shutdown.
cc: @StephanEwen @tillrohrmann
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation