Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9784] Fix inconsistent use of 'static' in AsyncIOExample.java #6298

Closed
wants to merge 1 commit into from

Conversation

nekrassov
Copy link
Contributor

What is the purpose of the change

This patch fixes inconsistent use of static in AsyncIOExample.java that can lead to incorrect code execution.

Brief change log

Changed executorService and random from static to instance-specific, removed no longer needed counter, and removed synchronization on class that's no longer needed either.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@yanghua
Copy link
Contributor

yanghua commented Jul 11, 2018

+1, from my side

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this fix @nekrassov and the review @yanghua. Merging this PR.

@asfgit asfgit closed this in 5363595 Jul 12, 2018
asfgit pushed a commit that referenced this pull request Jul 12, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants