[FLINK-10123] Use ExecutorThreadFactory instead of DefaultThreadFactory in RestServer/Client #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Till, scala checkstyle error : other travis build task also failed, because of some connection timeout. |
zentol
reviewed
Aug 12, 2018
| * limitations under the License. | ||
| */ | ||
|
|
||
| package akka.actor |
There was a problem hiding this comment.
@zentol here we should use this package.
There was a problem hiding this comment.
We need to use the same package as the Akka classes since ActorSystemImpl is package private private[akka]. It is a bit ugly but it should work.
zentol
approved these changes
Aug 12, 2018
tillrohrmann
force-pushed
the
executorThreadFactory
branch
from
bafd980
to
c2f5429
Compare
|
checkstyle error : |
tillrohrmann
force-pushed
the
executorThreadFactory
branch
from
c2f5429
to
74eadae
Compare
|
Thanks @yanghua. Fixed the PR. Let's see what Travis says this time :-) |
This closes apache#6339.
The RobustActorSystem has a configurable UncaughtExceptionHandler. Per default it is started with the FatalExitExceptionHandler. This handler terminates the JVM whenever it sees an uncaught exception. This closes apache#6334.
…ry in RestServer/Client Using the ExecutorThreadFactory hardens the system because it uses the FatalExitExceptionHandler as UncaughtExceptionHandler which terminates the JVM in case of an exception. This closes apache#6539.
tillrohrmann
force-pushed
the
executorThreadFactory
branch
from
74eadae
to
e307f92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Using the ExecutorThreadFactory hardens the system because it uses the FatalExitExceptionHandler
as UncaughtExceptionHandler which terminates the JVM in case of an exception.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation