Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11302] FlinkS3FileSystem uses an incorrect path for temporary files. #7458

Closed
wants to merge 4 commits into from

Conversation

art4ul
Copy link
Contributor

@art4ul art4ul commented Jan 10, 2019

What is the purpose of the change

This pull request fixes the bug FLINK-11302
AbstractS3FileSystemFactory uses config value CoreOptions.TMP_DIRS.
This value represented as a list of paths separated by the separator.
Instead of using the config value "as is" I split it by separator and use the first path as a temporary path for FlinkS3FileSystem

Brief change log

    • split TMP_DIRS config value by separator and use the first path as a temporary path for FlinkS3FileSystem*

Verifying this change

Added test that validates that produced by AbstractS3FileSystemFactory object will contain an only first path from multiple paths in config link

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (yes)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @art4ul ! I will merge later today.

@asfgit asfgit closed this in 291373a Jan 16, 2019
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
@jonpollock
Copy link

jonpollock commented Apr 11, 2019

I know this is already closed and merged, but I'd just like to point out that the constructor of the FlinkS3FileSystem calls RefCountedTmpFileCreator.inDirectories, passing it a single File object. This method takes multiple files and each will be used as a way of spreading the temp files over multiple directories.

The change you applied, limits this to just the first directory in the LOCAL_DIRS. I understand that you probably didn't want to change the Constructor signature, but I think that is only used in AbstractS3FileSystemFactory.

In any case, thank you for your work and this solve a problem I've had for a few hours now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants