[FLINK-10910][e2e] Hardened Kubernetes e2e test. #7507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aljoscha Could you maybe have a look at it? |
aljoscha
approved these changes
Jan 29, 2019
| @@ -37,10 +39,28 @@ function cleanup { | |||
| rm -rf ${OUTPUT_VOLUME} | |||
| } | |||
|
|
|||
| function check_kubernetes_status { | |||
There was a problem hiding this comment.
I'm guessing these work because the return value of a bash function is implicitly the return value of the last executed command?
Maybe we can make that more explicit so that we don't accidentally break it in the future if someone adds another line after the last line. (This is also something I don't like that much about Scala ...)
Added check if minikube is running. If it is not we try to start it couple of times. If we do not succeed we fail with a descriptive message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check if minikube is running. If it is not we try to start it couple of times. If we do not succeed we fail with a descriptive message.
What is the purpose of the change
This PR should harden kubernetes e2e test. It checks if kubernetes is running. If not it tries to start it. If it fails it exits with a descriptive error message.
Verifying this change
Run
test_kubernetes_embedded_job.shscript. I've run ~100 times this test on travis, without a single failure (https://travis-ci.org/dawidwys/flink/builds/480346541). I also checked locally if it succeeds if minikube is not started.