Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11423] Propagate the error message from Main method to JarRunHandler #7573

Closed
wants to merge 1 commit into from

Conversation

lavkesh
Copy link

@lavkesh lavkesh commented Jan 24, 2019

What is the purpose of the change

  • We want to propgrate error occured in the filnk program submited by jar/run API to the client.

Brief change log

  • Added additional message into ProgramInvocationException thrown inside PackagedProgram.callMainMethod()

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: No
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? not applicable

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @lavkesh. LGTM. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants