Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11447][table] Deprecate new Table(TableEnvironment, String) #7651

Closed
wants to merge 5 commits into from

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Feb 4, 2019

What is the purpose of the change

This pull request deprecates the constructor new Table(TableEnvironment, String)

Brief change log

  • Deprecates new Table(TableEnvironment, String)
  • Introduces Table.lateralJoin, Table.leftOuterLateralJoin
  • Move the implicit of 'TableFunction to Table' to ExpressionDsl as otherwise this implicit always has the highest priority and TableFunction will always be converted to table which is not expected for joinLateral/leftOuterJoinLateral

Verifying this change

This change added tests and can be verified as follows:

(example:)

  • Added tests CorrelateStringExpressionTest.testCorrelateJoinsWithJoinLateral

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (yes)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs & JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 4, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ✅ 4. The [architecture] is sound.
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@dianfu
Copy link
Contributor Author

dianfu commented Feb 4, 2019

@twalthr @dawidwys Could you help to take a look at this PR when it's convenient for you? Thanks in advance.

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dianfu. I did a quick scan over the changes. Can you search again for outdated website docs or Javadocs. For example, the docs of {{org.apache.flink.table.api.functions.TableFunction}} still need an update. I will do a full review soon. Thanks.

@twalthr
Copy link
Contributor

twalthr commented Feb 4, 2019

@flinkbot approve description
@flinkbot approve consensus

@twalthr twalthr self-assigned this Feb 4, 2019
@dianfu
Copy link
Contributor Author

dianfu commented Feb 5, 2019

@twalthr Thanks a lot for the remind. I have updated the documentation.

@twalthr
Copy link
Contributor

twalthr commented Feb 5, 2019

@flinkbot approve all

Thanks for the update @dianfu. I spotted some additional usages but I will fix them while merging. In general the changes look good to me. I will do the final polishing and merge this.

@asfgit asfgit closed this in 6fb98b3 Feb 5, 2019
dianfu added a commit to dianfu/flink that referenced this pull request Feb 6, 2019
Deprecates the constructor usage of the Table class. This is
necessary for converting the class into a clean interface. See
also FLIP-32 for more information.

Use table.joinLateral() or table.leftOuterJoinLateral() instead.

This closes apache#7651.
@dianfu dianfu deleted the deprecate_table branch June 10, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants