-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-11447][table] Deprecate new Table(TableEnvironment, String) #7651
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dianfu. I did a quick scan over the changes. Can you search again for outdated website docs or Javadocs. For example, the docs of {{org.apache.flink.table.api.functions.TableFunction}} still need an update. I will do a full review soon. Thanks.
@twalthr Thanks a lot for the remind. I have updated the documentation. |
839bbbd
to
889250f
Compare
889250f
to
55bb16d
Compare
Deprecates the constructor usage of the Table class. This is necessary for converting the class into a clean interface. See also FLIP-32 for more information. Use table.joinLateral() or table.leftOuterJoinLateral() instead. This closes apache#7651.
What is the purpose of the change
This pull request deprecates the constructor new Table(TableEnvironment, String)
Brief change log
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation