Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12316][jdbc] Relax assertions #8251

Merged
merged 1 commit into from
Apr 26, 2019
Merged

[FLINK-12316][jdbc] Relax assertions #8251

merged 1 commit into from
Apr 26, 2019

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Apr 24, 2019

What is the purpose of the change

Relaxes the exception message assertion in JDBCFullTest#testEnrichedClassCastException such that it works under java 8 and 9+. The test was failing since the class names for Strings, Doubles etc. are different under Java 9.

The assertion now only checks for the part of the exception that we actually control.

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 24, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@tillrohrmann
Copy link
Contributor

@flinkbot approve all

@zentol zentol merged commit a639488 into apache:master Apr 26, 2019
@zentol zentol deleted the 12316 branch April 27, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants