-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13075][table-planner-blink] Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner #9197
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 623248e (Tue Aug 06 15:45:15 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…quire the TableSource return a modified schema in blink planner
Travis passed: https://travis-ci.com/TsReaper/flink/builds/120101168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -34,16 +34,21 @@ import org.apache.flink.table.sources.{TableSource, TableSourceUtil} | |||
class TableSourceTable[T]( | |||
val tableSource: TableSource[T], | |||
val isStreamingMode: Boolean, | |||
val statistic: FlinkStatistic) | |||
val statistic: FlinkStatistic, | |||
val selectedFields: Option[Array[Int]]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be simplified to val selectedFields: Option[Array[Int]] = None
. Then we don't need to introduce a new constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are Java invokers, so introduce this constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only left a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merging...
…quire the TableSource return a modified schema in blink planner This closes #9197
What is the purpose of the change
As the javadoc of
org.apache.flink.table.sources.ProjectableTableSource#projectFields
said, the table schema of theTableSource
copy must not be modified by this method. However,PushProjectIntoTableSourceScanRule
in blink planner requires the returning a table source with the modified table schema. This conflict with the javadoc and result in theTableSource
works for flink planner can't work for blink planner.This PR fixes
PushProjectIntoTableSourceScanRule
and related class to make it work for blink planner.Brief change log
PushProjectIntoTableSourceScanRule
so that the schema of the newly created table source is the same with the original one.Verifying this change
This change is already covered by existing tests, such as
TableSourceItCase
.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation